Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loader: migrate to getOptions #23455

Closed
wants to merge 1 commit into from
Closed

loader: migrate to getOptions #23455

wants to merge 1 commit into from

Conversation

rxiayth
Copy link
Contributor

@rxiayth rxiayth commented Oct 12, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@gireeshpunathil
Copy link
Member

@rxiayth - is it possible for you to add a commit message to this? thanks

@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 12, 2018
@rxiayth
Copy link
Contributor Author

rxiayth commented Oct 12, 2018

Node.js collaborators, add 👍 here to approve fast-tracking (@tniessen).

@tniessen
Copy link
Member

(I wrote the comment above from @rxiayth's laptop since mine wasn't around, sorry for the confusion.)

@addaleax addaleax added fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory. labels Oct 12, 2018
@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/17762/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 12, 2018
@Trott
Copy link
Member

Trott commented Oct 12, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17784/

@addaleax
Copy link
Member

Landed in 849aa1e, thanks for the help! 🎉

@addaleax addaleax closed this Oct 13, 2018
addaleax pushed a commit that referenced this pull request Oct 13, 2018
@rxiayth @addaleax
lib: migrate to getOptions in loaders.js
849aa1e 
PR-URL: #23455
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@rxiayth @jasnell
lib: migrate to getOptions in loaders.js
278775a 
PR-URL: #23455
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
addaleax pushed a commit that referenced this pull request Oct 20, 2018
@rxiayth @addaleax
lib: migrate to getOptions in loaders.js
a01858d 
PR-URL: #23455
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@rxiayth @MylesBorins
lib: migrate to getOptions in loaders.js
6acc891 
PR-URL: #23455
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@rxiayth @rvagg
lib: migrate to getOptions in loaders.js
187216e 
PR-URL: #23455
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@rxiayth @MylesBorins
lib: migrate to getOptions in loaders.js
6f01a79 
PR-URL: #23455
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@devsnek devsnek devsnek approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@rxiayth @gireeshpunathil @tniessen @addaleax @Trott @cjihrig @devsnek @trivikr